Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong replacement suggestion for UnnecessaryFilter #4807

Merged
merged 1 commit into from
May 3, 2022

Conversation

themkat
Copy link
Contributor

@themkat themkat commented May 3, 2022

Fixes #4806

size is a property/member, not a method/function, and does not take any inputs.

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #4807 (9e9c34c) into main (ca29f28) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #4807   +/-   ##
=========================================
  Coverage     84.72%   84.72%           
  Complexity     3426     3426           
=========================================
  Files           491      491           
  Lines         11260    11260           
  Branches       2069     2069           
=========================================
  Hits           9540     9540           
  Misses          674      674           
  Partials       1046     1046           
Impacted Files Coverage Δ
...arturbosch/detekt/rules/style/UnnecessaryFilter.kt 80.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca29f28...9e9c34c. Read the comment docs.

@BraisGabin BraisGabin merged commit 30af7dc into detekt:main May 3, 2022
@themkat themkat deleted the GH-4806 branch May 4, 2022 14:36
@cortinico cortinico added this to the 1.21.0 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong replacement suggestion for [UnnecessaryFilter]
3 participants